-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Godot 4.0 compile errors, update JavaScript integration, refactor code, and address minor issues #156
Conversation
Added a section to make it more clear to new users that this is self contained like vanilla Godot.
… code, and address minor issues Fixed compilation errors, improved RefCounted bindings, renamed ECMAScript to JavaScript, implemented JavaScriptCallable, fixed typos, updated GDExtension migration, updated JS modules, and refactored code for Godot 4.0. Co-Authored-By: Malik Ahmed <animanmaster@gmail.com>
It's ok to keep master to compatiable with godot master branch. |
Since I'm not able to work on this immediately. Here's the plan:
|
The current errors don't make sense: scons: *** [thirdparty/glslang/glslang/MachineIndependent/attribute.windows.editor.x86_64.o] Error 1
In file included from thirdparty/glslang/glslang/MachineIndependent/ParseHelper.h:53,
from thirdparty/glslang/glslang/MachineIndependent/attribute.cpp:41:
thirdparty/glslang/glslang/MachineIndependent/SymbolTable.h:648:18: error: 'uint32_t' does not name a type
648 | static const uint32_t LevelFlagBitOffset = 56;
| ``` |
Sounds related to this: godotengine/godot#77949 I get the same error locally if I try to build it using MSYS2 MinGW. Not sure if downgrading GCC to < 13 would change anything, but I can't afford to mess with it locally because it took me ages to get it working properly. You could also try with UCRT64 instead of mingw |
It builds when I copy the module into git godot engine https://github.com/V-Sekai/godot/tree/vsk-javascript. Note that only linux and windows platforms are set to build. |
subrepo: subdir: "modules/javascript" merged: "87c3a7d2b6d" upstream: origin: "https://github.com/Geequlim/ECMAScript.git" branch: "gd4-rebase" commit: "1c753617ee6" git-subrepo: version: "0.4.6" origin: "???" commit: "???"
subrepo: subdir: "modules/javascript" merged: "d062d5630b8" upstream: origin: "https://github.com/Geequlim/ECMAScript.git" branch: "gd4-rebase" commit: "b87a29e90bc" git-subrepo: version: "0.4.6" origin: "???" commit: "???"
Remove xsd check.
Co-Authored-By: jaune <jaunelacouleur@gmail.com>
Fix github actions CICD errors.
I am targeting master because of graph node changes. |
@jaune if you wish you can close it. |
Add icons
We have refactored the JavaScript integration to make it more efficient. We have also improved the readability of the code by adding comments and restructuring the code blocks. This will make it easier for other developers to understand and contribute to the project. Co-Authored-By: NicolasMerget <Nicolas.Merget@deutschebahn.com>
Refactor JavaScript integration and improve code readability.
To review the changes on top of gd4.
This is blocked on the build process with mvsc.